Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(jsii) --add-deprecated-warnings flag should not add warning when a non-deprecated class inherits a deprecated class #3102

Closed
nija-at opened this issue Oct 28, 2021 · 3 comments
Labels
bug This issue is a bug. module/jsii Issues affecting the `jsii` module. p1

Comments

@nija-at
Copy link
Contributor

nija-at commented Oct 28, 2021

🐛 Bug Report

It is acceptable for a non-deprecated class to inherit a deprecated class.
The --strip-deprecated flag correctly handles this, by not exporting the deprecated class and treating it as a private member.

However, the --add-deprecated-warnings flag does not account for this. It produces a warning when the non-deprecated subclass is used.

Example:

https://github.com/aws/aws-cdk/blob/c4ba858278bffe1a987ea8200c313f17f7f1cbe9/packages/%40aws-cdk/core/lib/bundling.ts#L251

BundlingDockerImage here is deprecated.

@nija-at nija-at added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2021
@nija-at nija-at changed the title (jsii) add-deprecated-warnings should not add warning when a non-deprecated class inherits a deprecated class (jsii) --add-deprecated-warnings flag should not add warning when a non-deprecated class inherits a deprecated class Oct 28, 2021
@NGL321 NGL321 added the p2 label Oct 29, 2021
@nija-at
Copy link
Contributor Author

nija-at commented Nov 1, 2021

@NGL321
Copy link
Contributor

NGL321 commented May 25, 2022

@otaviomacedo was this resolved with #3112?

@NGL321 NGL321 added module/jsii Issues affecting the `jsii` module. and removed needs-triage This issue or PR still needs to be triaged. labels May 25, 2022
@mrgrain mrgrain closed this as completed Apr 18, 2024
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. module/jsii Issues affecting the `jsii` module. p1
Projects
None yet
Development

No branches or pull requests

3 participants