Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): dates are mistreated as strings #2730

Merged
merged 5 commits into from
Mar 24, 2021
Merged

fix(go): dates are mistreated as strings #2730

merged 5 commits into from
Mar 24, 2021

Conversation

RomainMuller
Copy link
Contributor

Implements the correct code generation flow & runtime logic to correctly
handle jsii date values as *time.Time instances.

Fixes #2659

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller
fix(go): dates are mistreated as strings
f1ee585 
Implements the correct code generation flow & runtime logic to correctly
handle jsii date values as *time.Time instances.

Fixes #2659
@RomainMuller RomainMuller added bug This issue is a bug. language/go Regarding GoLang bindings effort/small Small work item – less than a day of effort compliance Missing or broken compliance tests module/pacmak Issues affecting the `jsii-pacmak` module module/runtime Issues affecting the `jsii-runtime` labels Mar 22, 2021
@RomainMuller RomainMuller requested a review from a team March 22, 2021 11:27
@RomainMuller RomainMuller self-assigned this Mar 22, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 22, 2021
MrArnoldPalmer
MrArnoldPalmer approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, special dependencies stuff is 👍🏻 much easier to reason about.

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Merging (with squash)...

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

Merging (with squash)...

@mergify mergify bot merged commit 2ba2ec4 into main Mar 24, 2021
@mergify mergify bot deleted the rmuller/go-dates branch March 24, 2021 10:24
@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. compliance Missing or broken compliance tests contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort language/go Regarding GoLang bindings module/pacmak Issues affecting the `jsii-pacmak` module module/runtime Issues affecting the `jsii-runtime`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go: dates are mistreated as strings
2 participants
@RomainMuller @MrArnoldPalmer