fix(python): accept Sequence[T] for array parameters #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of typing array (list) parameters as `typing.List[T]`, using the more flexible `typing.Sequence[T]` type, as recommended by the `typing` package documentation for this use-case. Using `List[T]` is inconvenient as it is invariant ([ref]), and requires very intentional typing, which elads to boilerplate. `Sequence[T]` is variant, which removes the need for boilerplate, as long as all items in the sequence match the expected type. [ref]: https://mypy.readthedocs.io/en/latest/common_issues.html#variance This was reported in aws/aws-cdk#13203
RomainMuller
added
language/python
RomainMuller
commented
Feb 24, 2021
| @@ -67,7 +67,7 @@ export function verifyGeneratedCodeFor( | |||
|
|
|||
| expect({ [TREE]: checkTree(outDir) }).toMatchSnapshot('<outDir>/'); | |||
|
|
|||
| if (targetName !== TargetName.PYTHON) { | |||
| if (targetName !== TargetName.PYTHON || process.env.SKIP_MYPY_CHECK) { | |||
There was a problem hiding this comment.
The Mypy check adds between 40 and 100 seconds to the execution... Disabling it temporarily can help iterating much faster...
MrArnoldPalmer
approved these changes
Feb 24, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of typing array (list) parameters as
typing.List[T], using themore flexible
typing.Sequence[T]type, as recommended by thetypingpackage documentation for this use-case.
Using
List[T]is inconvenient as it is invariant (ref), and requiresvery intentional typing, which elads to boilerplate.
Sequence[T]isvariant, which removes the need for boilerplate, as long as all items
in the sequence match the expected type.
This was reported in #4533
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.