Skip to content

Commit 8b234b7

Browse files
authored
fix(ecs): removed omitEmptyArray for placementConstraints (#27555) (#30382)
### Issue fixes #27555 Closes Half Fix [i.e, Allows user to give Empty Placement Constraints ] #27555 This PR does not address supporting empty placement strategies because of the following reason : [27555 : comment](#27572 (comment)) This was raised with the guidance from - [pr / 28431 : Comment ](#28431 (comment)) ### Reason for this change Users unable to give empty placementConstraints ### Description of how you validated changes - Added a UnitCase to cover with empty `[]` placementConstraints - Integration Tests ``` $ yarn integ test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js --update-on-failed ``` After integ tests were completed, `npm test` to verify the snapshot. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent af81264 commit 8b234b7

11 files changed

+3209
-4
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js.snapshot/IntegDefaultTestDeployAssert4E6713E1.assets.json

+19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js.snapshot/IntegDefaultTestDeployAssert4E6713E1.template.json

+36
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js.snapshot/aws-cdk-ecs-integ-test-with-empty-placement-constraint-stack.assets.json

+19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)