Skip to content

Commit 28c4be3

Browse files
authored
fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to get CFN types resolved in exports (#28768)
Issue still persists after #28680. ``` node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations. 1 import type { CloudFormation } from 'aws-sdk'; ~~~~~~~~~ Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1 ``` Types are still required as a direct dependency in package.json. Closes #28679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 507b709 commit 28c4be3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/@aws-cdk/cloudformation-diff/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"dependencies": {
2626
"@aws-cdk/aws-service-spec": "^0.0.53",
2727
"@aws-cdk/service-spec-types": "^0.0.53",
28+
"aws-sdk": "2.1576.0",
2829
"chalk": "^4",
2930
"diff": "^5.2.0",
3031
"fast-deep-equal": "^3.1.3",
@@ -38,7 +39,6 @@
3839
"@types/string-width": "^4.0.1",
3940
"fast-check": "^3.16.0",
4041
"jest": "^29.7.0",
41-
"aws-sdk": "2.1576.0",
4242
"ts-jest": "^29.1.2"
4343
},
4444
"repository": {

0 commit comments

Comments
 (0)