-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation/Inspection ask/tell #1206
Comments
I was actually hoping that one could just set n_configs=0 in get_initial_design, but this line seems to silently overwrite user intention and still asks for at least one configuration from the initial design. I think this is bad conduct. Either way the initial_design configuration is populated in the ConfigSelector._initial_design_configs and only executed/ask'ed for when ConfigSelector.iter is being called, which i think should only be done once the intensifier is being queried for a new configuration. So i suspect that an ask call will trigger this initial design config (checked this just now and it actually does) Similarly passing None to the |
Changing the previously mentioned line to _n_configs=max(0,min(...)) will indeed produce no initial design configs, but in turn raises -- This line warns us about a potential malfunction of smac without initial design configs, but as it turns out an ask will eventually collect the first config by however the int(max(0, min())) has the side effect, that once we set n_configs=1 scenario.n_trials=1 this will yield a int(max(0,0.25)) and in turn not sample a configuration from the initial_design despite our best intentions |
is not an issue. Only dependency is through the above mentioned line. I.e. in determining how many configs should be used in the initial design based off the assumed share of max_ratio of the trials : |
The text was updated successfully, but these errors were encountered: