Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Textmate: Bugged syntax highlightning for a class variable when concatenating with string. #365

Closed
alexr00 opened this issue Aug 9, 2019 · 1 comment

Comments

@alexr00
Copy link

alexr00 commented Aug 9, 2019

From @min0rr in microsoft/vscode#78767:
Example :

<?php
const A_DBNAME = 'BROADCAST_archive';

$sql = "SELECT TABLE_NAME FROM information_schema.TABLES WHERE TABLE_NAME LIKE 'zip%' AND TABLE_SCHEMA ='".ArchivationConfig::A_DBNAME."'";
?>

Problem is :
There is no syntax highlightning for constant ArchivationConfig::A_DBNAME. It is shown as a part of string.
The token ".ArchivationConfig::A_DBNAME." is categorized as
string.quoted.single.sql
source.sql.embedded.php
string.quoted.double.sql.php
source.php
meta.embedded.block.php
text.html.php

Here it is:
image

@rsese
Copy link

rsese commented Aug 9, 2019

Thanks for contributing!

I think this looks like a duplicate of #336 so you can subscribe there for updates if you'd like.


Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

@rsese rsese closed this as completed Aug 9, 2019
@rsese rsese added the duplicate label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants