Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do-what-I-mean follow-mode in switch-buffer #1491

Closed
Ambrevar opened this issue Jun 8, 2021 · 3 comments · Fixed by #1653
Closed

Do-what-I-mean follow-mode in switch-buffer #1491

Ambrevar opened this issue Jun 8, 2021 · 3 comments · Fixed by #1653
Labels

Comments

@Ambrevar
Copy link
Contributor

Ambrevar commented Jun 8, 2021

In commit b3dcf84 @jmercouris changed the behaviour of switch-buffer to not move the last buffer to the top.

While this is convenient when follow-mode is on, it removes the ability to easily "alt-tab" between the last two buffers.

@jmercouris Can you remind me of the rationale behind not shuffling buffers?

@Ambrevar Ambrevar added the high label Jun 8, 2021
@jmercouris
Copy link
Member

There are a couple of problems:

  1. invoking switch-buffers would shuffle the buffers, not showing you where you currently are
  2. you immediately lose mental context when invoking switch-buffer as the page would immediately switch

1 is a problem because if you think about set-url it prefills with the current URL. People are used to the current element being shown first, and then being mutated.

@jmercouris
Copy link
Member

Those may seem like the exact same problem twice, but they are slightly different. With point 1 above, I am trying to highlight that you don't want switch-buffers to actually change the recency of access for buffers.

@Ambrevar
Copy link
Contributor Author

For future information, the discussion related to the initial issue is in #1430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants