Make replacement slightly safer

andrecloutier · andrecloutier · commit d9c7e009ac0b · 2025-03-05T10:58:25.000-05:00
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -211,7 +211,7 @@ func (c *Config) loadSettings() error {
 
 func normalizePath(homeDir string, path string) string {
 	if strings.HasPrefix(path, "~") {
-		path = strings.Replace(path, "~", homeDir, 1)
+		path = filepath.Join(homeDir, path[1:])
 	}
 	return filepath.Clean(path)
 }

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ func (c *Config) loadSettings() error {`
`211`	`211`
`212`	`212`	`func normalizePath(homeDir string, path string) string {`
`213`	`213`	`if strings.HasPrefix(path, "~") {`
`214`		`- path = strings.Replace(path, "~", homeDir, 1)`
	`214`	`+ path = filepath.Join(homeDir, path[1:])`
`215`	`215`	`}`
`216`	`216`	`return filepath.Clean(path)`
`217`	`217`	`}`