Skip to content

Commit 60e4b36

Browse files
per1234aentinger
authored andcommitted
Improve board-specific configuration system in compile-examples CI workflow (#124)
Use the matrix.include key to customize the compile-examples CI workflow's matrix jobs with board type-specific configurations. This GitHub Actions feature allows defining additional properties for matrix jobs that match the filter. The previous approach for doing this was to use generated environment variable names, which worked but seemed likely to be confusing for anyone trying to decipher the workflow. I think the new approach is a little easier to understand and less hacky. I had hoped this would allow me to do away with the board.type system, but supplying lists of values to the filter keys isn't supported, you can't reference the env key from matrix, and YAML anchors aren't supported. So the board.type system remains the only way I can see to avoid redefining the configuration options for each board of the same type.
1 parent 5570e6c commit 60e4b36

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/compile-examples.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@ jobs:
2121
UNIVERSAL_LIBRARIES: '"ArduinoCloudThing" "Arduino_ConnectionHandler" "Arduino_DebugUtils" "ArduinoMqttClient"'
2222
# sketch paths to compile (recursive) for all boards
2323
UNIVERSAL_SKETCH_PATHS: '"examples/ArduinoIoTCloud-Advanced" "examples/ArduinoIoTCloud-Basic" "examples/utility/ArduinoIoTCloud_Travis_CI"'
24-
# board-specific sketches
25-
WIFI_SKETCH_PATHS: '"examples/utility/Provisioning" "examples/utility/WiFi_Cloud_Blink"'
26-
WAN_SKETCH_PATHS: ''
27-
GSM_SKETCH_PATHS: '"examples/utility/Provisioning" "examples/utility/GSM_Cloud_Blink"'
28-
NB_SKETCH_PATHS: '"examples/utility/Provisioning" "examples/utility/NB_Cloud_Blink"'
29-
ESP8266_SKETCH_PATHS: '"examples/utility/WiFi_Cloud_Blink_with_security_credentials"'
3024

3125
strategy:
3226
fail-fast: false

0 commit comments

Comments
 (0)