Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double compilation for AOT #363

Closed
timsgardner opened this issue May 3, 2019 · 0 comments
Closed

double compilation for AOT #363

timsgardner opened this issue May 3, 2019 · 0 comments
Labels

Comments

@timsgardner
Copy link
Contributor

The menu item "AOT Compile" currently triggers two compilation passes (the second of which seemingly fails in the circumstance that there is a top-level (snapshot (->SomeDefmutable x y)) form).

I'm not completely clear why this causes a failure later, though protocols are twitchy about double-evaluation. In any event, we shouldn't be doing two compilation passes, it invites weird race conditions. The cause seems to be in Arcadia.Menu#AOTCompile:

        [MenuItem("Arcadia/AOT Compile")]
        public static void AOTCompile()
        {
            BuildPipeline.BuildInternal();
            BuildPipeline.BuildUser();
        }

Even if this works, however, there's still a question of how AOTing user code should work if Internal code is already AOT'd, and if doing one after the other can cause a problem. The safest approach is probably to clear all AOT'd code before every compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant