Skip to content

Commit f731992

Browse files
authored
Update RangerBasePlugin.java
1 parent dbde224 commit f731992

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java

+21-19
Original file line numberDiff line numberDiff line change
@@ -138,53 +138,55 @@ public RangerBasePlugin(RangerPluginConfig pluginConfig) {
138138
setIsFallbackSupported(pluginConfig.getBoolean(pluginConfig.getPropertyPrefix() + ".is.fallback.supported", false));
139139
setServiceAdmins(serviceAdmins);
140140

141-
String kerbPrefix = pluginConfig.getPropertyPrefix() + ".kerberos";
142-
boolean initKerb = pluginConfig.getBoolean(kerbPrefix + ".initialize", false);
141+
String ugiPrefix = pluginConfig.getPropertyPrefix() + ".ugi";
142+
boolean initUgi = pluginConfig.getBoolean(ugiPrefix + ".initialize", false);
143143

144-
if (initKerb) {
145-
String kerbLoginType = pluginConfig.get(kerbPrefix + ".login.type");
144+
if (initUgi) {
145+
String ugiLoginType = pluginConfig.get(ugiPrefix + ".login.type");
146146

147-
if (StringUtils.equalsIgnoreCase(kerbLoginType, "keytab")) {
148-
String kerbPrincipal = pluginConfig.get(kerbPrefix + ".keytab.principal");
149-
String kerbKeytab = pluginConfig.get(kerbPrefix + ".keytab.file");
147+
if (StringUtils.equalsIgnoreCase(ugiLoginType, "keytab")) {
148+
String principal = pluginConfig.get(ugiPrefix + ".keytab.principal");
149+
String keytab = pluginConfig.get(ugiPrefix + ".keytab.file");
150150

151-
if (StringUtils.isNotBlank(kerbPrincipal) && StringUtils.isNotBlank(kerbKeytab)) {
152-
LOG.info("Kerberos login - ugi: principal={}, keytab={}", kerbPrincipal, kerbKeytab);
151+
if (StringUtils.isNotBlank(principal) && StringUtils.isNotBlank(keytab)) {
152+
LOG.info("UGI login: principal={}, keytab={}", principal, keytab);
153153

154154
try {
155-
UserGroupInformation.loginUserFromKeytab(kerbPrincipal, kerbKeytab);
155+
UserGroupInformation.loginUserFromKeytab(principal, keytab);
156156
} catch (IOException excp) {
157-
LOG.error("Kerberos login - ugi: failed", excp);
157+
LOG.error("UGI login: failed", excp);
158158

159159
throw new RuntimeException(excp);
160160
}
161161
} else {
162-
String msg = String.format("Kerberos login - ugi: invalid configuration: %s=%s, %s=%s", kerbPrefix + ".keytab.principal", kerbPrincipal, kerbPrefix + ".keytab.file", kerbKeytab);
162+
String msg = String.format("UGI login: invalid configuration: %s=%s, %s=%s", ugiPrefix + ".keytab.principal", principal, ugiPrefix + ".keytab.file", keytab);
163163

164164
LOG.error(msg);
165165

166166
throw new RuntimeException(msg);
167167
}
168-
} else if (StringUtils.equalsIgnoreCase(kerbLoginType, "jaas")) {
169-
String appConfig = pluginConfig.get(kerbPrefix + ".jaas.appconfig");
168+
} else if (StringUtils.equalsIgnoreCase(ugiLoginType, "jaas")) {
169+
String jaasAppConfig = pluginConfig.get(ugiPrefix + ".jaas.appconfig");
170+
171+
if (StringUtils.isNotBlank(jaasAppConfig)) {
172+
LOG.info("UGI login: jaasAppConfig={}", jaasAppConfig);
170173

171-
if (StringUtils.isNotBlank(appConfig)) {
172174
try {
173-
MiscUtil.setUGIFromJAASConfig(appConfig);
175+
MiscUtil.setUGIFromJAASConfig(jaasAppConfig);
174176
} catch (Exception excp) {
175-
LOG.error("Kerberos login - jaas: appconfig={} failed", appConfig, excp);
177+
LOG.error("UGI login: jaasAppConfig={} failed", jaasAppConfig, excp);
176178

177179
throw new RuntimeException(excp);
178180
}
179181
} else {
180-
String msg = String.format("Kerberos login - jaas: invalid configuration: %s=%s", kerbPrefix + ".jaas.appconfig", appConfig);
182+
String msg = String.format("UGI login: invalid configuration: %s=%s", ugiPrefix + ".jaas.appconfig", jaasAppConfig);
181183

182184
LOG.error(msg);
183185

184186
throw new RuntimeException(msg);
185187
}
186188
} else {
187-
LOG.warn("Kerberos login: invalid configuration {}={}", kerbPrefix + ".login.type", kerbLoginType);
189+
LOG.warn("UGI login: invalid configuration {}={}", ugiPrefix + ".login.type", ugiLoginType);
188190
}
189191
}
190192

0 commit comments

Comments
 (0)