Skip to content

Commit be35f64

Browse files
FredrikAndersonmichael-o
authored andcommitted
[MSITE-945] Remove dependency on Commons IO
Co-authored-by: Michael Osipov <[email protected]> This closes #202
1 parent 6fc5d17 commit be35f64

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed

pom.xml

-7
Original file line numberDiff line numberDiff line change
@@ -487,13 +487,6 @@ under the License.
487487
<scope>test</scope>
488488
</dependency>
489489

490-
<dependency>
491-
<groupId>commons-io</groupId>
492-
<artifactId>commons-io</artifactId>
493-
<version>2.16.1</version>
494-
<scope>test</scope>
495-
</dependency>
496-
497490
<!-- test -->
498491
<dependency>
499492
<groupId>org.apache.maven.plugin-testing</groupId>

src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020

2121
import java.io.File;
2222
import java.nio.charset.StandardCharsets;
23+
import java.nio.file.Files;
2324
import java.util.Arrays;
2425
import java.util.Collections;
2526
import java.util.HashMap;
2627
import java.util.List;
2728
import java.util.Map;
2829

29-
import org.apache.commons.io.FileUtils;
3030
import org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout;
3131
import org.apache.maven.bridge.MavenRepositorySystem;
3232
import org.apache.maven.doxia.tools.SiteTool;
@@ -220,12 +220,12 @@ public void davDeployThruProxyWitAuthzInProxy() throws Exception {
220220
private void assertContentInFiles() throws Exception {
221221
File htmlFile = new File(siteTargetPath, "site" + File.separator + "index.html");
222222
assertTrue(htmlFile.exists());
223-
String fileContent = FileUtils.readFileToString(htmlFile, StandardCharsets.UTF_8);
224-
assertTrue(fileContent.contains("Welcome to Apache Maven"));
223+
String htmlContent = new String(Files.readAllBytes(htmlFile.toPath()), StandardCharsets.UTF_8);
224+
assertTrue(htmlContent.contains("Welcome to Apache Maven"));
225225

226226
File cssFile = new File(siteTargetPath, "site" + File.separator + "css" + File.separator + "maven-base.css");
227227
assertTrue(cssFile.exists());
228-
String cssContent = FileUtils.readFileToString(cssFile, StandardCharsets.UTF_8);
228+
String cssContent = new String(Files.readAllBytes(cssFile.toPath()), StandardCharsets.UTF_8);
229229
assertTrue(cssContent.contains("background-image: url(../images/collapsed.gif);"));
230230
}
231231

src/test/java/org/apache/maven/plugins/site/deploy/AuthAsyncProxyServlet.java

+8-4
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,13 @@
2626

2727
import java.io.File;
2828
import java.io.IOException;
29-
import java.util.*;
29+
import java.nio.file.Files;
30+
import java.util.ArrayList;
31+
import java.util.Base64;
32+
import java.util.Enumeration;
33+
import java.util.List;
34+
import java.util.Map;
3035

31-
import org.apache.commons.io.FileUtils;
32-
import org.apache.commons.io.IOUtils;
3336
import org.eclipse.jetty.proxy.AsyncProxyServlet;
3437

3538
/**
@@ -121,7 +124,8 @@ public void service(ServletRequest req, ServletResponse res) throws ServletExcep
121124

122125
if (request.getMethod().equalsIgnoreCase("PUT") && targetPath != null) {
123126
File targetFile = new File(siteTargetPath, targetPath);
124-
FileUtils.writeByteArrayToFile(targetFile, IOUtils.toByteArray(request.getInputStream()));
127+
targetFile.getParentFile().mkdirs();
128+
Files.copy(request.getInputStream(), targetFile.toPath());
125129
}
126130

127131
response.setStatus(HttpServletResponse.SC_OK);

src/test/java/org/apache/maven/plugins/site/deploy/SimpleDavServerHandler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,11 @@
2525

2626
import java.io.File;
2727
import java.io.IOException;
28+
import java.nio.file.Files;
2829
import java.util.ArrayList;
2930
import java.util.Enumeration;
3031
import java.util.List;
3132

32-
import org.apache.commons.io.FileUtils;
33-
import org.apache.commons.io.IOUtils;
3433
import org.eclipse.jetty.server.Handler;
3534
import org.eclipse.jetty.server.Request;
3635
import org.eclipse.jetty.server.Server;
@@ -74,7 +73,8 @@ public void handle(String target, Request r, HttpServletRequest request, HttpSer
7473

7574
if (request.getMethod().equalsIgnoreCase("PUT")) {
7675
File targetFile = new File(siteTargetPath, targetPath);
77-
FileUtils.writeByteArrayToFile(targetFile, IOUtils.toByteArray(request.getInputStream()));
76+
targetFile.getParentFile().mkdirs();
77+
Files.copy(request.getInputStream(), targetFile.toPath());
7878
}
7979

8080
// PrintWriter writer = response.getWriter();

0 commit comments

Comments
 (0)