-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Add support for building statistics array for nested types #45474
Comments
as follow up our privious conversation and the implementation of 1.apporpiate type for nested array I think we should address the first case to make it possible the second one |
I've submitted my first pull request which is about to implement extract_regex_span and it is currently under review. I'd like to start working on this issue, However I'm still gaining experience in C++ and it maybe take some time to implement it. Nonetheless, I approciate if you could assign the issue to me. |
You can do it by yourself by just adding "take" only comment! Document: https://arrow.apache.org/docs/developers/bug_reports.html#issue-assignment |
take |
I found that it seems the arrow/cpp/src/arrow/array/statistics.h Lines 57 to 66 in 0fbf982
should I add support for these types? |
Yes but let's work on it as a separated task. Because |
I've created the separate issue for this #45664 , However I think it's better to send a pull request for it after the current issue is solved |
Describe the enhancement requested
arrow::RecordBatch::MakeStatisticsArray()
can build a statistics array of a record batch. But it doesn't support nested types yet. We should use the rule that is used by RecordBatch message https://arrow.apache.org/docs/format/Columnar.html#ipc-recordbatch-message to compute column indexes for nested types.See also: https://arrow.apache.org/docs/format/StatisticsSchema.html#schema
Component(s)
C++
The text was updated successfully, but these errors were encountered: