Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending redeal #49

Open
ThorvaldAagaard opened this issue Jan 23, 2025 · 6 comments
Open

Extending redeal #49

ThorvaldAagaard opened this issue Jan 23, 2025 · 6 comments

Comments

@ThorvaldAagaard
Copy link

I am adding a lot of new criterias used for selecting a deal.

It is not clear for me, which should be part of redeal, and which I should keep in my own code, and the line between properties (hcp, qp etc) and functions (balanced, losers, etc) doesn't seem clear.

I am sure you can improve my implementation, but let me know if you are interested in adding some of it to redeal

@anntzer
Copy link
Owner

anntzer commented Jan 23, 2025

I am not really actively developing redeal anymore (I guess I'll try to maintain it in a working state but no more than that); the feature set is essentially based on what was present in the original tcl deal. I would suggest that you just fork the project if you want to add many features to it.

@ThorvaldAagaard
Copy link
Author

I have forked it, so you can later take a look and see if there is anything you want to add.

But I had some trouble of defining Shape for 10-card suits, and it would be nice to some way of specifying a singlesuited hand.

@anntzer
Copy link
Owner

anntzer commented Jan 23, 2025

What do you exactly want to specify?

@ThorvaldAagaard
Copy link
Author

I want to specify a onesuited hand along with other handtypes

Image

This is working fine, but will never find a hand with a 10-card suit

I was thinking about using l1

@anntzer
Copy link
Owner

anntzer commented Jan 23, 2025

Smartstacking (https://github.com/anntzer/redeal?tab=readme-ov-file#smartstacking) may help for very rare hand types.

@ThorvaldAagaard
Copy link
Author

Yes, but I am creating logic for bidding, and then the logic is input for the handgenerator to generate samples, so I am not aiming at rare handtypes, I just need to be sure, they are possible.

But we seem to have a general problem with shape, not just redeal but in general, perhaps we should use Hex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants