Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select All" does not work properly in image occlusion in 24.04 #3107

Closed
goodbird2 opened this issue Mar 31, 2024 · 7 comments
Closed

"Select All" does not work properly in image occlusion in 24.04 #3107

goodbird2 opened this issue Mar 31, 2024 · 7 comments

Comments

@goodbird2
Copy link

goodbird2 commented Mar 31, 2024

使用 全选+组合 功能, 制作卡片之后, 我发现没有任何遮挡在上面, 只显示图像。
我发誓我没有修改任何有关图片遮挡模板, 所以这应该是版本更新带来的错误。能尽快修复吗, 我很喜欢这个新功能。

@dae
Copy link
Member

dae commented Apr 1, 2024

@krmanik this appears to have regressed in #3052 - the select all feature doesn't seem to be working correctly anymore. If the shapes are manually selected, they can be grouped.

@krmanik
Copy link
Contributor

krmanik commented Apr 1, 2024

I have tested it and created similar issues here, https://forums.ankiweb.net/t/it-seems-that-the-group-cloze-is-not-working-as-expected-in-io the issues seem to be on touch based device. I am implementing fix for it now. Also editing the note and making grop seems to not working.

@krmanik
Copy link
Contributor

krmanik commented Apr 1, 2024

I am not able to understand that it is working properly in add mode, but it is causing issue in edit mode.

@dae
Copy link
Member

dae commented Apr 1, 2024

I reproduced the issue the OP mentioned by testing on a Mac - haven't tried on iOS. It's broken in add mode too. Create two rectangles, click on 'select all', then 'group', then 'add'. The card doesn't show any rectangles when it's reviewed.

@krmanik
Copy link
Contributor

krmanik commented Apr 1, 2024

The select all needs to skip bounding box selection, then it will work, I will push the fix quickly.

@dae dae changed the title 2404版本图像遮挡错误 "Select All" does not work properly in image occlusion in 24.04 Apr 1, 2024
@dae
Copy link
Member

dae commented Apr 10, 2024

Associated PR: #3109

@abdnh
Copy link
Collaborator

abdnh commented Apr 11, 2024

Can be closed.

@dae dae closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants