This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(virtualRepeat): Recover from scroll events that occur when hidden #6389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -197,6 +197,7 @@ VirtualRepeatContainerController.prototype.updateSize = function() { | |||
| ? this.$element[0].clientWidth | |||
| : this.$element[0].clientHeight; | |||
|
|
|||
| this.handleScroll_(); | |||
There was a problem hiding this comment.
Maybe add a comment as to why you're calling the scroll handler here?
kseamon
force-pushed
the
autocomplete-white-whale
branch
from
b98e870 to
cff2654
Compare
|
LGTM |
jelbourn
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5448.