Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(chips): allow to specify md-max-chips attribute through md-contacts #10827

Closed
wants to merge 2 commits into from

Conversation

kylekatarnls
Copy link
Contributor

Hi,

We would need for a limit of the number of contacts. Could we pass the md-max-chips options from md-contacts to md-chips the same way than other options?

Sub-question: could it be tagged as a patch version?

Thanks,

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Aug 2, 2017
@kylekatarnls
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Aug 2, 2017
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.6 Sep 5, 2017
@angular angular deleted a comment from googlebot Dec 18, 2017
@angular angular deleted a comment from googlebot Dec 18, 2017
@Splaktar
Copy link
Member

Splaktar commented Dec 18, 2017

Thank you for your contribution! Please follow the commit message guidelines.

@Splaktar Splaktar added the needs: review This PR is waiting on review from the team label Dec 18, 2017
@Splaktar Splaktar self-assigned this Dec 18, 2017
@Splaktar Splaktar added the P5: nice to have These issues will not be fixed without community contributions. label Dec 18, 2017
@Splaktar Splaktar changed the title Allow to specify md-chips md-max-chips attribute through md-contacts feat(chips): allow to specify md-max-chips attribute through md-contacts Dec 18, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar modified the milestones: 1.1.7, - Backlog Jan 30, 2018
@Splaktar Splaktar added type: enhancement needs: unit tests This PR needs unit tests to cover the changes being proposed and removed type: feature labels Oct 19, 2020
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test to verify this functionality?

Splaktar pushed a commit that referenced this pull request Dec 6, 2020
@Splaktar Splaktar removed the needs: review This PR is waiting on review from the team label Dec 6, 2020
@Splaktar Splaktar removed this from the - Backlog milestone Dec 6, 2020
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. and removed P5: nice to have These issues will not be fixed without community contributions. labels Dec 6, 2020
@Splaktar
Copy link
Member

Splaktar commented Dec 6, 2020

There were some issues with this PR that I have resolved in PR #12050.

Splaktar pushed a commit that referenced this pull request Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ needs: unit tests This PR needs unit tests to cover the changes being proposed P4: minor Minor issues. May not be fixed without community contributions. type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants