fix(material/select): added ecs click handling in host keydown #30520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The esc button was processed only in the overlay, which led to the container not closing in sidenav. Fixes angular#30507
Veribelll
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Feb 19, 2025
| @@ -1033,6 +1033,10 @@ export class MatSelect | |||
| hasDeselectedOptions ? option.select() : option.deselect(); | |||
| } | |||
| }); | |||
| } else if (event.keyCode === ESCAPE && !hasModifierKey(event)) { | |||
There was a problem hiding this comment.
While this would fix the issue at the moment, we have a TODO to move all of this logic into _handleOverlayKeydown for better interop with the rest of the overlays. Once that happens the sidenav use case will break again so I'm not sure we should land the change just to have it regress later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The esc button was processed only in the overlay, which led to the container not closing in sidenav.
Fixes #30507