Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit f009b23

Browse files
fix(dialog): remove dialogOpenClass to get in line with v2.3
1 parent 3e5a58e commit f009b23

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

src/dialog/dialog.js

-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ dialogModule.provider("$dialog", function(){
2020
backdropClass: 'modal-backdrop',
2121
transitionClass: 'fade',
2222
triggerClass: 'in',
23-
dialogOpenClass: 'modal-open',
2423
resolve:{},
2524
backdropFade: false,
2625
dialogFade:false,
@@ -132,7 +131,6 @@ dialogModule.provider("$dialog", function(){
132131

133132
$compile(self.modalEl)($scope);
134133
self._addElementsToDom();
135-
body.addClass(self.options.dialogOpenClass);
136134

137135
// trigger tranisitions
138136
setTimeout(function(){
@@ -152,7 +150,6 @@ dialogModule.provider("$dialog", function(){
152150
var self = this;
153151
var fadingElements = this._getFadingElements();
154152

155-
body.removeClass(self.options.dialogOpenClass);
156153
if(fadingElements.length > 0){
157154
for (var i = fadingElements.length - 1; i >= 0; i--) {
158155
$transition(fadingElements[i], removeTriggerClass).then(onCloseComplete);

src/modal/test/modal.spec.js

-2
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,10 @@ describe('Give ui.boostrap.modal', function() {
9999
});
100100

101101
it('should use global $dialog options', function() {
102-
provider.options({dialogOpenClass: 'test-open-modal'});
103102
elm = $compile(templateGenerator('modalShown'))($scope);
104103
expect($document.find('.test-open-modal').length).toBe(0);
105104
$scope.$apply('modalShown = true');
106105
expect($document.find('body > div.modal').length).toBe(1);
107-
expect($document.find('.test-open-modal').length).not.toBe(0);
108106
$scope.$apply('modalShown = false');
109107
});
110108

0 commit comments

Comments
 (0)