Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create preview deployment and control the url name #54

Closed
esakal opened this issue May 31, 2020 · 1 comment
Closed

create preview deployment and control the url name #54

esakal opened this issue May 31, 2020 · 1 comment
Labels
Type: Question Further information is requested

Comments

@esakal
Copy link

esakal commented May 31, 2020

Hello,
Can I run this action and control the name of the preview url? the same as the automatic integration is doing by appending the PR version to the preview url? I want to be able to provide to the action a string that identify versions to append to my domain, so if my domain is my-domain.now.sh with the version it will be http://my-domain-v1-0-0.now.sh/

Also, can I prevent the integration on specific branches? so it will work on PRs and not on master branch commits?

Can I do that with this action?
Thanks
Eran.

@amondnet
Copy link
Owner

amondnet commented Jun 5, 2020

Can I run this action and control the name of the preview url? the same as the automatic integration is doing by appending the PR version to the preview url? I want to be able to provide to the action a string that identify versions to append to my domain, so if my domain is my-domain.now.sh with the version it will be http://my-domain-v1-0-0.now.sh/

Currently, it can't. It will be possible in the next version.
amondnet/vercel-action#7

Also, can I prevent the integration on specific branches? so it will work on PRs and not on master branch commits?

https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags

When using the push and pull_request events, you can configure a workflow to run on specific branches or tags. For a pull_request event, only branches and tags on the base are evaluated. If you define only tags or only branches, the workflow won't run for events affecting the undefined Git ref.

on:
  push:
    # Sequence of patterns matched against refs/heads
    branches:    
      # Push events on master branch
      - master
      # Push events to branches matching refs/heads/mona/octocat
      - 'mona/octocat'
      # Push events to branches matching refs/heads/releases/10
      - 'releases/**'
    # Sequence of patterns matched against refs/tags
    tags:        
      - v1             # Push events to v1 tag
      - v1.*           # Push events to v1.0, v1.1, and v1.9 tags

@amondnet amondnet added the Type: Question Further information is requested label Jun 5, 2020
@amondnet amondnet modified the milestone: v19.0.1 Jun 5, 2020
@amondnet amondnet closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants