Skip to content

Commit 049f051

Browse files
Liu ShixinSasha Levin
Liu Shixin
authored and
Sasha Levin
committed
mm/hwpoison: clear MF_COUNT_INCREASED before retrying get_any_page()
commit 2a57d83 upstream. Hulk Robot reported a panic in put_page_testzero() when testing madvise() with MADV_SOFT_OFFLINE. The BUG() is triggered when retrying get_any_page(). This is because we keep MF_COUNT_INCREASED flag in second try but the refcnt is not increased. page dumped because: VM_BUG_ON_PAGE(page_ref_count(page) == 0) ------------[ cut here ]------------ kernel BUG at include/linux/mm.h:737! invalid opcode: 0000 [#1] PREEMPT SMP CPU: 5 PID: 2135 Comm: sshd Tainted: G B 5.16.0-rc6-dirty torvalds#373 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 RIP: release_pages+0x53f/0x840 Call Trace: free_pages_and_swap_cache+0x64/0x80 tlb_flush_mmu+0x6f/0x220 unmap_page_range+0xe6c/0x12c0 unmap_single_vma+0x90/0x170 unmap_vmas+0xc4/0x180 exit_mmap+0xde/0x3a0 mmput+0xa3/0x250 do_exit+0x564/0x1470 do_group_exit+0x3b/0x100 __do_sys_exit_group+0x13/0x20 __x64_sys_exit_group+0x16/0x20 do_syscall_64+0x34/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xae Modules linked in: ---[ end trace e99579b570fe0649 ]--- RIP: 0010:release_pages+0x53f/0x840 Link: https://lkml.kernel.org/r/[email protected] Fixes: b94e028 ("mm,hwpoison: try to narrow window race for free pages") Signed-off-by: Liu Shixin <[email protected]> Reported-by: Hulk Robot <[email protected]> Reviewed-by: Oscar Salvador <[email protected]> Acked-by: Naoya Horiguchi <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 1a0a171 commit 049f051

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

mm/memory-failure.c

+1
Original file line numberDiff line numberDiff line change
@@ -2201,6 +2201,7 @@ int soft_offline_page(unsigned long pfn, int flags)
22012201
} else if (ret == 0) {
22022202
if (soft_offline_free_page(page) && try_again) {
22032203
try_again = false;
2204+
flags &= ~MF_COUNT_INCREASED;
22042205
goto retry;
22052206
}
22062207
}

0 commit comments

Comments
 (0)