Refine eslint rules

Author: amatiasq

.eslintrc

@@ -10,6 +10,7 @@
   "ignorePatterns": [".cache/**", "dist/**", "node_modules/**"],
   "rules": {
     "@typescript-eslint/explicit-module-boundary-types": 0,
+    "@typescript-eslint/no-explicit-any": 0,
     "@typescript-eslint/no-non-null-assertion": 0
   }
 }

src/0-dom/isMobile.ts

@@ -3,7 +3,7 @@ const FIRST_MATCH =
 const SECOND_MATCH =
   /1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw-(n|u)|c55\/|capi|ccwa|cdm-|cell|chtm|cldc|cmd-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc-s|devi|dica|dmob|do(c|p)o|ds(12|-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(-|_)|g1 u|g560|gene|gf-5|g-mo|go(\.w|od)|gr(ad|un)|haie|hcit|hd-(m|p|t)|hei-|hi(pt|ta)|hp( i|ip)|hs-c|ht(c(-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i-(20|go|ma)|i230|iac( |-|\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\/)|klon|kpt |kwc-|kyo(c|k)|le(no|xi)|lg( g|\/(k|l|u)|50|54|-[a-w])|libw|lynx|m1-w|m3ga|m50\/|ma(te|ui|xo)|mc(01|21|ca)|m-cr|me(rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|-([1-8]|c))|phil|pire|pl(ay|uc)|pn-2|po(ck|rt|se)|prox|psio|pt-g|qa-a|qc(07|12|21|32|60|-[2-7]|i-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h-|oo|p-)|sdk\/|se(c(-|0|1)|47|mc|nd|ri)|sgh-|shar|sie(-|m)|sk-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h-|v-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl-|tdg-|tel(i|m)|tim-|t-mo|to(pl|sh)|ts(70|m-|m3|m5)|tx-9|up(\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|yas-|your|zeto|zte-/i;
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const ua = navigator.userAgent || navigator.vendor || (window as any).opera;
 
-export const isMobile = FIRST_MATCH.test(ua) || SECOND_MATCH.test(ua.substr(0, 4));
+export const isMobile =
+  FIRST_MATCH.test(ua) || SECOND_MATCH.test(ua.substr(0, 4));

src/0-dom/page-visibility.ts

@@ -1,16 +1,14 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 import { emitter } from '@amatiasq/emitter';
 
 const { isHidden, eventName } = getKeyNames();
 const emitVisibilityChange = emitter<boolean>();
 
-type VisibilityChangeListener = Parameters<typeof emitVisibilityChange.subscribe>[0];
+type VisibilityChangeListener = Parameters<
+  typeof emitVisibilityChange.subscribe
+>[0];
 
 document.addEventListener(
   eventName,
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-  // @ts-ignore
   () => emitVisibilityChange(!document[isHidden]),
   false,
 );
@@ -29,21 +27,21 @@ function getKeyNames() {
     return {
       isHidden: 'hidden',
       eventName: 'visibilitychange',
-    };
+    } as const;
   }
 
   if ((document as any).msHidden != null) {
     return {
-      isHidden: 'msHidden',
-      eventName: 'msvisibilitychange',
-    };
+      isHidden: 'msHidden' as 'hidden',
+      eventName: 'msvisibilitychange' as 'visibilitychange',
+    } as const;
   }
 
   if ((document as any).webkitHidden != null) {
     return {
-      isHidden: 'webkitHidden',
-      eventName: 'webkitvisibilitychange',
-    };
+      isHidden: 'webkitHidden' as 'hidden',
+      eventName: 'webkitvisibilitychange' as 'visibilitychange',
+    } as const;
   }
 
   throw unsupportedBrowser();

src/1-core/messageBus.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 import { v4 as uuid } from 'uuid';
 
 import { Emitter, emitter } from '@amatiasq/emitter';

src/3-github/GHRepositoryApi.ts

@@ -23,8 +23,7 @@ const CREATE_REPO_CONFIG = {
   is_template: false,
 };
 
-// This is necessary because of https://github.com/microsoft/TypeScript/issues/14174#issuecomment-856812565
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
+// any is necessary here because of https://github.com/microsoft/TypeScript/issues/14174#issuecomment-856812565
 export type StagedFiles = Record<string, any>;
 
 export interface GHRepoNode {

src/4-storage/middleware/GHGistStore.ts

@@ -1,9 +1,9 @@
 import { AsyncStore } from '../AsyncStore';
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
+// THIS IS JUST PLACEHOLDER
+// CODE NOT IN USE
 export type GithubGists = any;
 
-// THIS IS JUST PLACEHOLDER
 export class GHGistStore implements AsyncStore {
   constructor(private readonly gists: GithubGists) {}
 

src/4-storage/middleware/ResilientOnlineStore.ts

@@ -76,7 +76,6 @@ export class ResilientOnlineStore<ReadOptions, WriteOptions>
     }
 
     // TS doesn't recognize params as valid parameters for method
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const promise: Promise<void> = (this.remote[method] as any)(...params);
 
     return promise.catch(reason => {
@@ -96,7 +95,6 @@ export class ResilientOnlineStore<ReadOptions, WriteOptions>
     this.pending.length = 0;
 
     for (const { method, params } of copy) {
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       (this[method] as any)(params);
     }
   }

src/6-hooks/useNavigator.ts

@@ -43,7 +43,6 @@ export function useNavigator() {
   return new Navigator(history, history.location.pathname);
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 function acceptNoteOrId(op: (id: NoteId) => any) {
   return (noteOrId: Note | NoteId) =>
     op(typeof noteOrId === 'string' ? noteOrId : noteOrId.id);

src/7-components/Editor/MonacoExtensions.ts

@@ -101,7 +101,7 @@ function defineSemanticTokens(monaco: Monaco) {
 
       return {
         data: new Uint32Array(data),
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        // null is valid but type definition complains
         resultId: null as any,
       };
     },

src/7-components/NotesList/NoteGroup.tsx

@@ -38,8 +38,7 @@ export function NoteGroup({ group, notes }: { group: string; notes: Note[] }) {
 
   return (
     <details className={cn.join(' ')} data-group={group} open={isOpen}>
-      {/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
-      <summary className="group-title" onClick={onGroupClicked as any}>
+      <summary className="group-title" onClick={onGroupClicked}>
         <Icon name="angle-right" className="icon-button group-caret" />
         <span className="group-name">{group}</span>
         <i className="counter">{notes.length}</i>
@@ -54,7 +53,7 @@ export function NoteGroup({ group, notes }: { group: string; notes: Note[] }) {
   );
 }
 
-function onGroupClicked(event: MouseEvent) {
+function onGroupClicked(event: React.MouseEvent<HTMLElement, MouseEvent>) {
   const target = (event.currentTarget as HTMLElement)
     .parentElement as HTMLDetailsElement;
 

src/7-components/atoms/InputField.tsx

@@ -95,7 +95,6 @@ export function InputField({
   }
 
   function resetContent() {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     ref.current!.innerText = value;
   }
 }

src/util/debugMethods.ts

@@ -1,16 +1,15 @@
 let indent = 0;
 
 export function debugMethods<Key extends string>(
-  // eslint-disable-next-line @typescript-eslint/ban-types
-  self: Record<Key, Function>,
+  self: Record<Key, (...args: any[]) => any>,
   methods: Key[],
   label?: string,
 ) {
   const className = self.constructor.name;
   methods.forEach(method => {
     const original = self[method];
 
-    self[method] = (...args: any[]) => {
+    self[method] = (...args: unknown[]) => {
       const x = '  '.repeat(indent++);
       const y = label ? ` [${label}]` : '';
 

src/util/serialization.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function serialize(x: any) {
   return JSON.stringify(x, null, 2);
 }