Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: derive Clone for HashBuilder #72

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat: derive Clone for HashBuilder #72

merged 1 commit into from
Dec 4, 2024

Conversation

shekhirin
Copy link
Contributor

No description provided.

@shekhirin shekhirin added the enhancement New feature or request label Dec 4, 2024
mattsse
mattsse approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this clone is fairly expensive,

this derive is technically fine, just expensive

@mattsse mattsse merged commit 29c9f98 into main Dec 4, 2024
19 of 21 checks passed
@mattsse mattsse deleted the alexey/hash-builder-clone branch December 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @fgimenez @mattsse