Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] feat(sol!)!: improve sol call bindings #880

Open
yash-atreya opened this issue Feb 18, 2025 · 0 comments · Fixed by #884
Open

[Feature] feat(sol!)!: improve sol call bindings #880

yash-atreya opened this issue Feb 18, 2025 · 0 comments · Fixed by #884
Assignees
Labels
breaking enhancement New feature or request
Milestone

Comments

@yash-atreya
Copy link
Member

yash-atreya commented Feb 18, 2025

Component

sol! macro

Describe the feature you would like

Currently for SolCall's with no params or exactly one param we generate the following bindings:

sol! {
    function totalSupply() returns (uint256);
    function balanceOf(address) returns (uint256);
}

struct totalSupplyCall {}

struct balanceOf { owner: Address } 

Proposing the following changes:

// Unit struct
struct totalSupplyCall;

// Tuple struct 
struct balanceOf(pub Address);

Additional context

No response

@yash-atreya yash-atreya added enhancement New feature or request breaking labels Feb 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 18, 2025
@yash-atreya yash-atreya self-assigned this Feb 19, 2025
@yash-atreya yash-atreya moved this from Todo to Ready for Review in Alloy Feb 21, 2025
@jenpaff jenpaff added this to the v1.0 milestone Feb 24, 2025
@yash-atreya yash-atreya moved this from Ready for Review to Reviewed in Alloy Mar 3, 2025
@yash-atreya yash-atreya moved this from Reviewed to Ready for Review in Alloy Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants