-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add circleci to pouch to validate markdown files #961
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
allencloud:add-circleci
Mar 25, 2018
Merged
feature: add circleci to pouch to validate markdown files #961
allencloud
merged 1 commit into
AliyunContainerService:master
from
allencloud:add-circleci
Mar 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Sun <[email protected]>
The error message will be like the following and to understand
|
LGTM, I am going to merge this first to check if this is correct in circleCI. Please feel free to ping me if anything unexpected happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
areas/docs
kind/feature
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
size/S
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
We need a standard to validate all MarkDown files in Pouch project. After finding all related tools, I decided to try markdownlint (https://github.com/markdownlint/markdownlint).
We have already use travisCI to finish unit test and integration test, this time I try to take advantages of circleCI to finish this part.
In the future, I will support webhook of circleCI in @pouchrobot to make it info pull request circleCI error when it fails.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
None
Ⅳ. Describe how to verify it
None
Ⅴ. Special notes for reviews
Currently I think the circleCI will fail with no doubt, since no one write markdown files according to markdownlint.
cc @HusterWan @Letty5411