Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit-tests for core AttachVolume #1688

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

forienlauo
Copy link
Contributor

Ⅰ. Describe what this PR did

#1635: add unit-tests for core AttachVolume

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

NONE

Ⅳ. Describe how to verify it

NONE

Ⅴ. Special notes for reviews

NONE

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @forienlauo
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1688 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1688      +/-   ##
=========================================
+ Coverage   41.16%   41.2%   +0.03%     
=========================================
  Files         274     274              
  Lines       18091   18091              
=========================================
+ Hits         7447    7454       +7     
+ Misses       9729    9727       -2     
+ Partials      915     910       -5
Impacted Files Coverage Δ
daemon/mgr/system.go 75% <0%> (-1.73%) ⬇️
ctrd/image.go 77.47% <0%> (-0.55%) ⬇️
daemon/mgr/container.go 50.23% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
storage/volume/core.go 58.53% <0%> (+1.95%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️

@allencloud
Copy link
Collaborator

PTAL @rudyfly @shaloulcy
Thanks a lot.

@rudyfly
Copy link
Collaborator

rudyfly commented Aug 7, 2018

LGTM

@rudyfly rudyfly merged commit 4f53f10 into AliyunContainerService:master Aug 7, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 7, 2018
@allencloud allencloud changed the title test: add unit-tests for core AttachVolume test: add unit-tests for core AttachVolume Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants