Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add top command in upgrade test suite #1554

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

allencloud
Copy link
Collaborator

@allencloud allencloud commented Jun 19, 2018

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

add top command in upgrade test suite to make run a long running container.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

add top command in upgrade test suite

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1554 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
+ Coverage   41.22%   41.25%   +0.02%     
==========================================
  Files         266      266              
  Lines       17313    17313              
==========================================
+ Hits         7138     7142       +4     
+ Misses       9288     9286       -2     
+ Partials      887      885       -2
Impacted Files Coverage Δ
daemon/mgr/container.go 49.33% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️

@Letty5411
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants