Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: return container.LogPath with ContainerStatusResponse #1401

Merged
merged 1 commit into from
May 24, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented May 24, 2018

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

return container.LogPath with ContainerStatusResponse

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/log kind/bug This is bug report for project size/XS labels May 24, 2018
@starnop starnop changed the title fix: return container.LogPath with ContainerStatusResponse bugfix: return container.LogPath with ContainerStatusResponse May 24, 2018
Signed-off-by: Starnop <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1401 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
- Coverage   38.55%   38.54%   -0.02%     
==========================================
  Files         248      248              
  Lines       16516    16517       +1     
==========================================
- Hits         6368     6366       -2     
- Misses       9328     9330       +2     
- Partials      820      821       +1
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 0% <0%> (ø) ⬆️
daemon/containerio/container_io.go 59.74% <0%> (-1.3%) ⬇️

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 24, 2018
@HusterWan HusterWan merged commit 48eb589 into AliyunContainerService:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/log kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants