test: split cli_run_test into several files #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letty5411
changed the title
Letty5411
force-pushed
the
0523-test
branch
3 times, most recently
from
f647600 to
6a888fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
=======================================
Coverage 38.55% 38.55%
=======================================
Files 248 248
Lines 16516 16516
=======================================
Hits 6368 6368
Misses 9328 9328
Partials 820 820
|
fuweid
reviewed
May 23, 2018
test/cli_run_blkio_test.go
Outdated
|
|
||
| // test if cgroup has record the real value | ||
| containerID := result[0].ID | ||
| { |
test/cli_run_blkio_test.go
Outdated
| c.Assert(result[0].HostConfig.BlkioWeightDevice[0].Path, check.Equals, testDisk) | ||
| c.Assert(result[0].HostConfig.BlkioWeightDevice[0].Weight, check.Equals, uint16(100)) | ||
|
|
||
| // test if cgroup has record the real value |
There was a problem hiding this comment.
Please remove the comment since it is useless code
test/cli_run_cgroup_test.go
Outdated
| if !strings.Contains(string(out), "314572800") { | ||
| c.Fatalf("unexpected output %s expected %s\n", string(out), "314572800") | ||
| } | ||
|
|
test/cli_run_cgroup_test.go
Outdated
|
|
||
| } | ||
|
|
||
| // TestRunInvalidCgroupParent checks that a specially-crafted cgroup parent doesn't cause Docker to crash or start modifying /. |
test/cli_run_cgroup_test.go
Outdated
| } | ||
|
|
||
| func testRunInvalidCgroupParent(c *check.C, cgroupParent, cleanCgroupParent, name string) { | ||
| command.PouchRun("run", "-m", "300M", "--cgroup-parent", cgroupParent, "--name", name, busyboxImage, "cat", "/proc/self/cgroup").Assert(c, icmd.Success) |
There was a problem hiding this comment.
Could we follow the guide about keeping the line around 80 chars? It can help us to read the code.
Letty5411
force-pushed
the
0523-test
branch
2 times, most recently
from
b9b43a2 to
6f12e19
Compare
Signed-off-by: letty <[email protected]>
|
LGTM Nice! @Letty5411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: letty [email protected]
Ⅰ. Describe what this PR did
Fix error usage of package
commandin cli_run_test.go. And separate this file into several files.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews