Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorder function sequence to make it more reasonable #1296

Merged
merged 1 commit into from
May 10, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

This pr tries to make container, image, network, volume interface's implementation much more in order. This will make go files much more readable.

In addition, I split two files exec_bridge.go and container_exec.go since they are quite decoupled, I think.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Describe how you did it

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

@codecov-io
Copy link

Codecov Report

Merging #1296 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1296     +/-   ##
=========================================
- Coverage    15.4%   15.31%   -0.1%     
=========================================
  Files         174      176      +2     
  Lines       11026    11014     -12     
=========================================
- Hits         1699     1687     -12     
  Misses       9208     9208             
  Partials      119      119
Impacted Files Coverage Δ
apis/server/exec_bridge.go 0% <0%> (ø)
apis/server/volume_bridge.go 0% <0%> (ø) ⬆️
apis/server/image_bridge.go 15% <0%> (ø) ⬆️
daemon/mgr/container_exec.go 0% <0%> (ø)
daemon/mgr/container.go 0% <0%> (ø) ⬆️
daemon/mgr/image.go 0% <0%> (ø) ⬆️
daemon/mgr/network.go 3.48% <0%> (ø) ⬆️
daemon/mgr/volume.go 0% <0%> (ø) ⬆️
apis/server/container_bridge.go 0% <0%> (ø) ⬆️
apis/server/network_bridge.go 0% <0%> (ø) ⬆️
... and 3 more

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 10, 2018
@HusterWan HusterWan merged commit 188acff into AliyunContainerService:master May 10, 2018
@allencloud allencloud deleted the reorder branch May 10, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants