feature: add rm flag in pouch run command #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
+ Coverage 15.56% 15.61% +0.04%
==========================================
Files 172 172
Lines 9744 9752 +8
==========================================
+ Hits 1517 1523 +6
Misses 8119 8119
- Partials 108 110 +2
|
rudyfly
reviewed
Apr 13, 2018
| @@ -52,6 +52,8 @@ func (rc *RunCommand) addFlags() { | |||
| flagSet.BoolVarP(&rc.attach, "attach", "a", false, "Attach container's STDOUT and STDERR") | |||
| flagSet.BoolVarP(&rc.stdin, "interactive", "i", false, "Attach container's STDIN") | |||
| flagSet.BoolVarP(&rc.detach, "detach", "d", false, "Run container in background and print container ID") | |||
| flagSet.BoolVar(&rc.rm, "rm", false, "Automatically remove the container after it exits") | |||
|
|
|||
There was a problem hiding this comment.
I think exits is ok.
There was a problem hiding this comment.
I am on the side of exits.
cli/run.go
Outdated
|
|
||
| if rc.rm { | ||
| if err := apiClient.ContainerRemove(ctx, containerName, true); err != nil { | ||
| return fmt.Errorf("failed to stop container %s: %v", containerName, err) |
Signed-off-by: Ace-Tang <[email protected]>
allencloud
reviewed
Apr 17, 2018
|
|
||
| if rc.rm { | ||
| if err := apiClient.ContainerRemove(ctx, containerName, true); err != nil { | ||
| return fmt.Errorf("failed to remove container %s: %v", containerName, err) |
There was a problem hiding this comment.
If error happens at this point, shall we return an exit code of non-zero?
With the change, we still return exit code of 0.
There was a problem hiding this comment.
As it a error happend here, this behaviour will get a error message, and of course, it should not be exit of 0, it will get exit code of 1 .
There was a problem hiding this comment.
sorry, I misunderstand your point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
add rm flag in pouch run command
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews