Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useFavicon doesn't work on Safari #2126

Closed
hhhluke opened this issue Mar 20, 2023 · 3 comments · Fixed by #2132
Closed

useFavicon doesn't work on Safari #2126

hhhluke opened this issue Mar 20, 2023 · 3 comments · Fixed by #2132
Labels
documentation Improvements or additions to documentation

Comments

@hhhluke
Copy link

hhhluke commented Mar 20, 2023

useFavicon document

Demo doesn't work on Safari
@goodjun
Copy link
Contributor

goodjun commented Mar 21, 2023 •
edited
Loading

I did some research and found out that Safari currently does not support dynamic changing of favicons.

Brady Eidson (Apple software engineer) says:

We (Apple) intentionally do not want the ability to script favicons.

do we need to update the document? @crazylxr

@liuyib
Copy link
Collaborator

liuyib commented Mar 21, 2023

I did some research and found out that Safari currently does not support dynamic changing of favicons.

Brady Eidson (Apple software engineer) says:

We (Apple) intentionally do not want the ability to script favicons.

do we need to update the document? @crazylxr

Thanks for your help, would you like to contribute a PR that include a FAQ to explain this?

@liuyib liuyib added the documentation Improvements or additions to documentation label Mar 21, 2023
@goodjun
Copy link
Contributor

goodjun commented Mar 21, 2023

Sure, I am very willing.

@goodjun goodjun mentioned this issue Mar 21, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update useFavicon docs goodjun/hooks
3 participants
@hhhluke @goodjun @liuyib