feat(appregistry): avoid panics in flattened processor

Author: ecordell

.gitignore

@@ -16,3 +16,6 @@ bin
 
 # Ignore sqlite
 *.db
+
+# Igore apprclient meta
+pkg/apprclient/openapi/git_push.sh

pkg/apprclient/openapi/git_push.sh

@@ -18,22 +18,22 @@ func TestProcessWithFlattenedFormat(t *testing.T) {
 		Typeflag: tar.TypeDir,
 		Name:     "/",
 	}
-	bundleAML := &tar.Header{
+	bundleYAML := &tar.Header{
 		Typeflag: tar.TypeReg,
 		Name:     "bundle.yaml",
 	}
 
 	workingDirectory, err := ioutil.TempDir(".", "manifests-")
 	require.NoError(t, err)
-	defer func(){
+	defer func() {
 		require.NoError(t, os.RemoveAll(workingDirectory))
 	}()
 
 	doneGot, errGot := checker.Process(root, "test", workingDirectory, nil)
 	assert.NoError(t, errGot)
 	assert.False(t, doneGot)
 
-	doneGot, errGot = checker.Process(bundleAML, "test", workingDirectory, nil)
+	doneGot, errGot = checker.Process(bundleYAML, "test", workingDirectory, nil)
 	assert.NoError(t, errGot)
 	assert.False(t, doneGot)
 
@@ -45,22 +45,22 @@ func TestProcessWithNestedBundleFormat(t *testing.T) {
 
 	// Simulate a flattened format as used by Operator Courier
 	headers := []*tar.Header{
-		&tar.Header{Name: "manifests", Typeflag: tar.TypeDir},
-		&tar.Header{Name: "manifests/etcd", Typeflag: tar.TypeDir},
-		&tar.Header{Name: "manifests/etcd/0.6.1", Typeflag: tar.TypeDir},
-		&tar.Header{Name: "manifests/etcd/0.6.1/etcdcluster.crd.yaml", Typeflag: tar.TypeReg},
-		&tar.Header{Name: "manifests/etcd/0.6.1/etcdoperator.clusterserviceversion.yaml", Typeflag: tar.TypeReg},
-		&tar.Header{Name: "manifests/etcd/etcd.package.yaml", Typeflag: tar.TypeReg},
+		{Name: "manifests", Typeflag: tar.TypeDir},
+		{Name: "manifests/etcd", Typeflag: tar.TypeDir},
+		{Name: "manifests/etcd/0.6.1", Typeflag: tar.TypeDir},
+		{Name: "manifests/etcd/0.6.1/etcdcluster.crd.yaml", Typeflag: tar.TypeReg},
+		{Name: "manifests/etcd/0.6.1/etcdoperator.clusterserviceversion.yaml", Typeflag: tar.TypeReg},
+		{Name: "manifests/etcd/etcd.package.yaml", Typeflag: tar.TypeReg},
 	}
 
 	workingDirectory, err := ioutil.TempDir(".", "manifests-")
 	require.NoError(t, err)
-	defer func(){
+	defer func() {
 		require.NoError(t, os.RemoveAll(workingDirectory))
 	}()
 
 	for _, header := range headers {
-		doneGot, errGot := checker.Process(header,"test", workingDirectory, nil)
+		doneGot, errGot := checker.Process(header, "test", workingDirectory, nil)
 		assert.NoError(t, errGot)
 
 		if checker.IsNestedBundleFormat() {

pkg/appregistry/checker_test.go

@@ -51,6 +51,10 @@ func (w *flattenedProcessor) Process(header *tar.Header, manifestName, workingDi
 		return
 	}
 
+	if len(manifest.Packages) == 0 {
+		err = fmt.Errorf("no packages found")
+		return
+	}
 	// now let's write each file to a directory
 	packageName := manifest.Packages[0].PackageName
 
@@ -108,7 +112,7 @@ func (w *flattenedProcessor) Process(header *tar.Header, manifestName, workingDi
 func writeYamlToFile(filepath, content string) error {
 	fo, err := os.Create(filepath)
 	if err != nil {
-		panic(err)
+		return err
 	}
 
 	defer fo.Close()