Skip to content

Commit 53b9cb8

Browse files
meisterTcopybara-github
authored andcommitted
Catch NumberFormatException while trying to parse thread id.
Fixes bazelbuild#14949. PiperOrigin-RevId: 439775241
1 parent e982f2a commit 53b9cb8

File tree

1 file changed

+8
-1
lines changed
  • src/main/java/com/google/devtools/build/lib/profiler

1 file changed

+8
-1
lines changed

src/main/java/com/google/devtools/build/lib/profiler/Profiler.java

+8-1
Original file line numberDiff line numberDiff line change
@@ -1021,7 +1021,14 @@ private static long getSortIndex(String threadName) {
10211021
return MAX_SORT_INDEX;
10221022
}
10231023

1024-
long extractedNumber = Long.parseLong(numberMatcher.group());
1024+
long extractedNumber;
1025+
try {
1026+
extractedNumber = Long.parseLong(numberMatcher.group());
1027+
} catch (NumberFormatException e) {
1028+
// If the number cannot be parsed, e.g. is larger than a long, the actual position is not
1029+
// really relevant.
1030+
return MAX_SORT_INDEX;
1031+
}
10251032

10261033
if (threadName.startsWith("skyframe-evaluator")) {
10271034
return SKYFRAME_EVALUATOR_SHIFT + extractedNumber;

0 commit comments

Comments
 (0)