Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to time-machine #7655

Closed
Dreamsorcerer opened this issue Oct 5, 2023 · 2 comments · Fixed by #7656
Closed

Migrate to time-machine #7655

Dreamsorcerer opened this issue Oct 5, 2023 · 2 comments · Fixed by #7656
Labels
good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/

Comments

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Oct 5, 2023 •
edited
Loading

It looks like freezegun is considered an abandoned project at this point.
We should look at migrating the tests to time-machine instead:
https://pypi.org/project/time-machine/

See, for example: spulec/freezegun#511
@Dreamsorcerer Dreamsorcerer added good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ labels Oct 5, 2023
@Dreamsorcerer
Copy link
Member Author

Seems to only be used in tests/test_cookiejar.py.

@gruebel
Copy link
Contributor

gruebel commented Oct 5, 2023

hey @Dreamsorcerer,

if it is ok, I would like to take it. Happy to finally be able to contribute back to the project 🍻

@gruebel gruebel mentioned this issue Oct 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace freezegun with time_machine gruebel/aiohttp
2 participants
@Dreamsorcerer @gruebel