Fixed multithread issue in CTX. Closes jgaa#128

Author: jgaa

Diff for: CMakeLists.txt

@@ -5,7 +5,7 @@ if (DEFINED ENV{RESTC_CPP_VERSION})
 endif()
 
 if (NOT DEFINED RESTC_CPP_VERSION)
-    set(RESTC_CPP_VERSION 0.92.0)
+    set(RESTC_CPP_VERSION 0.93.0)
 endif()
 
 if(NOT DEFINED RESTC_BOOST_VERSION)
@@ -56,9 +56,9 @@ if (NOT RESTC_CPP_LOG_WITH_INTERNAL_LOG AND NOT RESTC_CPP_LOG_WITH_LOGFAULT AND
     set(RESTC_CPP_LOG_WITH_INTERNAL_LOG ON)
 endif()
 
-set(RESTC_CPP_LOG_LEVEL_STR "info" CACHE STRING "Limit logs to: none, error, warn, info, debug, trace")
+set(RESTC_CPP_LOG_LEVEL_STR "trace" CACHE STRING "Limit logs to: none, error, warn, info, debug, trace")
 
-option(RESTC_CPP_LOG_JSON_SERIALIZATION "Enable trace logging for json serialization debugging")
+option(RESTC_CPP_LOG_JSON_SERIALIZATION "Enable trace logging for json serialization debugging" OFF)
 
 option(RESTC_CPP_WITH_ZLIB "Use zlib" ON)
 

Diff for: include/restc-cpp/ConnectionPool.h

@@ -21,7 +21,7 @@ class ConnectionPool
         const Connection::Type connectionType,
         bool new_connection_please = false) = 0;
 
-    virtual std::future<std::size_t> GetIdleConnections() const = 0;
+    virtual size_t GetIdleConnections() const = 0;
     static std::shared_ptr<ConnectionPool> Create(RestClient& owner);
 
     /*! Close the connection-pool

Diff for: include/restc-cpp/Socket.h

@@ -11,6 +11,8 @@
 #include <boost/system/error_code.hpp>
 
 #include "restc-cpp/typename.h"
+#include "restc-cpp/logging.h"
+
 #include "error.h"
 
 namespace restc_cpp {
@@ -68,6 +70,10 @@ class ExceptionWrapper {
         try {
             return fn();
         } catch (const boost::system::system_error& ex) {
+
+            RESTC_CPP_LOG_TRACE_("ExceptionWrapper: " << ex.what()
+                                 << ", value=" << ex.code());
+
             if (ex.code().value() == boost::system::errc::operation_canceled) {
                 if (reason_ == Socket::Reason::TIME_OUT) {
                     throw RequestTimeOutException();

Diff for: include/restc-cpp/internals/helpers.h

@@ -7,3 +7,5 @@
 #else
 #   define LOCK_
 #endif
+
+#define LOCK_ALWAYS_ std::lock_guard<std::mutex> lock_{mutex_}

Diff for: include/restc-cpp/logging.h

@@ -107,7 +107,8 @@ class Logger {
 
 }
 
-#define RESTC_CPP_TEST_LOGGING_SETUP(level) RestcCppTestStartLogger(level)
+//#define RESTC_CPP_TEST_LOGGING_SETUP(level) RestcCppTestStartLogger(level)
+#define RESTC_CPP_TEST_LOGGING_SETUP(level) RestcCppTestStartLogger("trace")
 
 inline void RestcCppTestStartLogger(const std::string& level = "info") {
     auto llevel = restc_cpp::LogLevel::INFO;

Diff for: include/restc-cpp/restc-cpp.h

@@ -174,6 +174,11 @@ class Request {
         general_callback_t beforeWriteFn;
         general_callback_t afterWriteFn;
         std::string bindToLocalAddress; // host:port
+#ifdef  RESTC_CPP_THREADED_CTX
+        size_t threads = 4; // Threads created for the Client.
+#else
+        size_t threads = 1;
+#endif
     };
 
     virtual const Properties& GetProperties() const = 0;
@@ -419,6 +424,8 @@ class RestClient {
      */
     virtual void CloseWhenReady(bool wait = true) = 0;
 
+    virtual bool IsClosed() const noexcept = 0;
+
     /*! Factory */
     static std::unique_ptr<RestClient> Create();
 
@@ -449,6 +456,7 @@ class RestClient {
     static std::unique_ptr<RestClient>
         Create(boost::asio::io_service& ioservice);
 
+
     protected:
         virtual std::unique_ptr<DoneHandler> GetDoneHandler() = 0;
 };