Finished initial socks5 implementation without authentication

Author: jgaa

README.md

@@ -247,6 +247,8 @@ Please refer to the [tutorial](doc/Tutorial.md) for more examples.
   - Override RequestBody to let the library pull for data when required.
   - Write directly to the outgoing DataWriter when data is required.
   - Just provide a C++ object and let the library serialize it directly to the wire.
+- HTTP Proxy support
+- SOCKS5 Proxy support (naive implementatin for now, no support for authentication).
 
 # Current Status
 The project has been in public BETA since April 11th 2017.

ci/mock-backends/docker-compose.yml

@@ -19,6 +19,8 @@ services:
 
     socks:
         image: jgaafromnorth/shinysocks
+        environment:
+          - LOG_LEVEL=trace
         ports:
           - "3004:1080"
         links: 

create-and-run-containers.sh

@@ -13,6 +13,7 @@ else
     exit -1
 fi
 
+docker-compose stop
 docker-compose build
 docker-compose up -d
 docker ps

src/RequestImpl.cpp

@@ -33,7 +33,7 @@ const std::string& Request::Proxy::GetName() {
 namespace {
 
 static constexpr char SOCKS5_VERSION = 0x05;
-static constexpr char SOCKS5_TCP_STREAM = 0x02;
+static constexpr char SOCKS5_TCP_STREAM = 0x01;
 static constexpr char SOCKS5_MAX_HOSTNAME_LEN = 255;
 static constexpr char SOCKS5_IPV4_ADDR = 0x01;
 static constexpr char SOCKS5_IPV6_ADDR = 0x04;
@@ -150,18 +150,18 @@ bool isCompleteSocks5ConnectReply(uint8_t *buf, size_t len) {
 
     size_t hdr_len = 5; // Mandatory bytes
 
-    switch(buf[2]) {
+    switch(buf[3]) {
     case SOCKS5_IPV4_ADDR:
-        hdr_len += 4;
+        hdr_len += 4 + 1;
         break;
     case SOCKS5_IPV6_ADDR:
-        hdr_len += 16;
+        hdr_len += 16 + 1;
         break;
     case SOCKS5_HOSTNAME_ADDR:
         if (len < 4) {
             return false; // We need the length field...
         }
-        hdr_len += buf[3];
+        hdr_len += buf[3] + 1 + 1;
     break;
     default:
         throw ProtocolException{"Wrong/unsupported SOCKS5 BINDADDR type: "s