set Base::upgrader_source_selection():$new_source to $source

when basenames are identical

Author: afragen

CHANGES.md

@@ -5,6 +5,7 @@
 * update `freemius/wordpress-sdk`
 * update `printf()` in `class Branches`
 * fix old `git-updater-pro` and `git-updater-additions` textdomains
+* update `Base::upgrader_source_selection()` to not `move_dir()` when basenames of `$source` and `$new_source` are identical, fixes potential issue with release assets
 
 #### 12.4.0 / 2024-03-04
 * update `freemius/wordpress-sdk`

git-updater.php

@@ -12,7 +12,7 @@
  * Plugin Name:       Git Updater
  * Plugin URI:        https://git-updater.com
  * Description:       A plugin to automatically update GitHub hosted plugins, themes, and language packs. Additional API plugins available for Bitbucket, GitLab, Gitea, and Gist.
- * Version:           12.4.0.5
+ * Version:           12.4.0.6
  * Author:            Andy Fragen
  * License:           MIT
  * Domain Path:       /languages

src/Git_Updater/Base.php

@@ -502,12 +502,17 @@ public function upgrader_source_selection( $source, $remote_source, $upgrader, $
 
 		$new_source = $this->fix_misnamed_directory( $new_source, $remote_source, $upgrader_object, $slug );
 
+		if ( basename( $source ) === basename( $new_source ) ) {
+			$new_source = $source;
+		}
+
 		if ( trailingslashit( strtolower( $source ) ) !== trailingslashit( strtolower( $new_source ) ) ) {
 			$result = move_dir( $source, $new_source, true );
 			if ( \is_wp_error( $result ) ) {
 				return $result;
 			}
 		}
+
 		// Clean up $new_source directory.
 		add_action( 'upgrader_install_package_result', [ $this, 'delete_upgrade_source' ], 10, 2 );