no longer needed

Author: afragen

CHANGES.md

@@ -7,6 +7,7 @@
 * add `Private Package` option for `Additions`, these private packages are not to be used with bulk REST endpoints
 * switch to standard `uninstall.php` as issue with calling `Freemius` during their `after_uninstall` hook
 * add early exit in `get_repo_slugs()` during AJAX installation for Add-Ons
+* removed `Add_Ons::upgrader_source_selection` no longer needed
 
 #### 12.11.0 / 2025-02-02
 * update Additions to add additional listings

git-updater.php

@@ -12,7 +12,7 @@
  * Plugin Name:       Git Updater
  * Plugin URI:        https://git-updater.com
  * Description:       A plugin to automatically update GitHub hosted plugins, themes, and language packs. Additional API plugins available for Bitbucket, GitLab, Gitea, and Gist.
- * Version:           12.11.0.5
+ * Version:           12.11.0.6
  * Author:            Andy Fragen
  * License:           MIT
  * Domain Path:       /languages

src/Git_Updater/Add_Ons.php

@@ -45,7 +45,6 @@ public function load_hooks() {
 		add_action( 'admin_init', [ $this, 'addons_page_init' ] );
 		add_action( 'install_plugins_pre_plugin-information', [ $this, 'prevent_redirect_on_modal_activation' ] );
 		add_filter( 'plugins_api', [ $this, 'plugins_api' ], 99, 3 );
-		add_filter( 'upgrader_source_selection', [ $this, 'upgrader_source_selection' ], 10, 4 );
 
 		$this->add_settings_tabs();
 	}
@@ -153,46 +152,6 @@ public function plugins_api( $result, $action, $args ) {
 		return $result;
 	}
 
-	/**
-	 * Correctly rename addon for activation.
-	 *
-	 * @param string                           $source        Path fo $source.
-	 * @param string                           $remote_source Path of $remote_source.
-	 * @param \Plugin_Upgrader|\Theme_Upgrader $upgrader      An Upgrader object.
-	 * @param array                            $hook_extra    Array of hook data.
-	 *
-	 * @return string|\WP_Error
-	 */
-	public function upgrader_source_selection( string $source, string $remote_source, \Plugin_Upgrader|\Theme_Upgrader $upgrader, $hook_extra = [] ) {
-		global $wp_filesystem;
-
-		$new_source = $source;
-
-		// Rename plugins.
-		if ( $upgrader instanceof \Plugin_Upgrader ) {
-			foreach ( self::$addons as $addon ) {
-				if ( str_contains( $source, $addon ) ) {
-					$hook_extra['plugin'] = "{$addon}/{$addon}.php";
-					break;
-				}
-			}
-			if ( isset( $hook_extra['plugin'] ) ) {
-				$slug       = dirname( $hook_extra['plugin'] );
-				$new_source = trailingslashit( $remote_source ) . $slug;
-			}
-		}
-
-		if ( ! isset( $slug ) || basename( $source ) === $slug ) {
-			return $source;
-		}
-
-		if ( trailingslashit( strtolower( $source ) ) !== trailingslashit( strtolower( $new_source ) ) ) {
-			$wp_filesystem->move( $source, $new_source, true );
-		}
-
-		return trailingslashit( $new_source );
-	}
-
 	/**
 	 * Some method to insert cards for API plugin installation.
 	 *