Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting an Input value back to its original value will prevent any further changes to the changeset #532

Closed
ultish opened this issue Aug 21, 2020 · 3 comments

Comments

@ultish
Copy link

ultish commented Aug 21, 2020

Version

ember-changeset: 3.8.2
ember-cli: 3.16.2

Test Case

https://ember-twiddle.com/2131e7dac897f223941de3c49cb82ee5?openFiles=twiddle%5C.json%2C

Steps to reproduce

  1. In the input box, add some text after the word "Tom" eg "Tom1"
  2. IsPristine will now be false
  3. Delete the additional text you made so the input reverts back to "Tom"
  4. isPristine will now be true again
  5. Try to type in a value in the input box and it won't do anything anymore

Expected Behavior

Expect changeset to set the value even after it reverted itself back to a pristine state

Actual Behavior

The changeset doesn't set any new value after returning to a pristine state

If I rollback the changeset then I can type into the Input again. If you make the Input into "Tom" again, it'll get stuck again until a rollback

@ultish ultish changed the title Setting an Input value back to it's original value will prevent any further changes to the changeset Setting an Input value back to its original value will prevent any further changes to the changeset Aug 21, 2020
@snewcomer
Copy link
Collaborator

👋 Hi! Can you try 3.20?

#519 (comment)

@ultish
Copy link
Author

ultish commented Aug 22, 2020

Hi @snewcomer
Thank you for the tip, that has indeed fixed it 👍

Will ember 3.20+ be required going forward?

@ultish ultish closed this as completed Aug 22, 2020
@snewcomer
Copy link
Collaborator

Sadly yes. Some dev only instrumentation that was removed causes this issue (not prod though).

emberjs/ember.js#18961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants