Create skill matching test. Checks all the skill tags matches and creates a report.

Author: ggeop

run_tests.sh

@@ -1,4 +1,6 @@
 #!/usr/bin/env bash
 export PYTHONPATH="${PYTHONPATH}:./src/jarvis"
 source jarvis_virtualenv/bin/activate
-python -m unittest discover -s ./src -p "*tests.py"
+sudo service mongod start
+python -m unittest discover -s ./src -p "*tests.py"
+sudo service mongod stop

src/jarvis/jarvis/skills/skill_analyzer.py

@@ -44,7 +44,7 @@ def tags(self):
         tags_list = []
         for skill in self.skills:
             tags_list.append(skill['tags'].split(','))
-        return [' '.join(tag) for tag in tags_list]
+        return [','.join(tag) for tag in tags_list]
 
     def extract(self, user_transcript):
 
@@ -71,7 +71,7 @@ def _replace_math_symbols_with_words(self, transcript):
                     if value == word:
                         replaced_transcript += ' ' + key
             else:
-                replaced_transcript +=  ' ' + word
+                replaced_transcript += ' ' + word
         return replaced_transcript
 
     def _create_vectorizer(self):

src/jarvis/jarvis/utils/mapping.py

@@ -22,8 +22,9 @@
 
 math_symbols_mapping = {
     'equal': '=',
-    'open parentheses': '(',
-    'close parentheses':  ')',
+    # ---- The following symbols are disable because are not matched correctly with the math skill ----.
+    # 'open parentheses': '(',
+    # 'close parentheses':  ')',
     'plus': '+',
     'minus': '-',
     'asterisk': '*',

src/tests/E2E_tests.py

@@ -0,0 +1,78 @@
+# MIT License
+
+# Copyright (c) 2019 Georgios Papachristou
+
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+import unittest
+from unittest.mock import patch
+
+from jarvis.core.processor import Processor
+from jarvis import settings
+from jarvis.utils.mongoDB import db
+from jarvis.skills.skills_registry import BASIC_SKILLS
+
+
+def get_skill_name_from_call_args(call_agrs):
+    return call_agrs[0][0]['skill']['name']
+
+
+@patch('jarvis.core.processor.Processor._execute_skill')
+@patch('jarvis.core.processor.engines.TTTEngine')
+class TestSkillMatching(unittest.TestCase):
+
+    def test_all_skill_matches(self, mocked_ttt_engine, mocked_execute_skill):
+        """
+        In this test we examine the matches or  ALL skill tags with the functions
+        If all skills matched right then the test passes otherwise not.
+
+        At the end we print a report with all the not matched cases.
+
+        """
+
+        verifications_errors = []
+
+        self.processor = Processor(settings, db)
+        mocked_ttt_engine.return_value.recognize_input.return_value = 'hi'
+        self.processor.run()
+
+        for basic_skill in BASIC_SKILLS:
+            print('--------------------------------------------------------------------------------------')
+            print('Examine skill: {0}'.format(basic_skill.get('name')))
+            for tag in basic_skill.get('tags',).split(','):
+                # If the skill has matching tags
+                if tag:
+                    mocked_ttt_engine.return_value.recognize_input.return_value = tag
+                    self.processor.run()
+                    expected_skill = basic_skill.get('name')
+                    actual_skill = get_skill_name_from_call_args(mocked_execute_skill.call_args)
+                    try:
+                        self.assertEqual(expected_skill, actual_skill)
+                    except AssertionError as e:
+                        verifications_errors.append({'tag': tag, 'error': e})
+
+        print('-------------------------------------- SKILLS MATCHING REPORT --------------------------------------')
+        if verifications_errors:
+            for increment, e in enumerate(verifications_errors):
+                print('{0})'.format(increment))
+                print('Not correct match with tag: {0}'.format(e.get('tag')))
+                print('Assertion values (expected != actual): {0}'.format(e.get('error')))
+            raise AssertionError
+        else:
+            print('All skills matched correctly!')