Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: addaleax/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test-tls-session-cache
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 29, 2018

  1. test: speed up parallel/test-tls-session-cache 

    This test had some unnecessary timeouts that made it run for a
much longer time than necessary (about 9 s rather than 0.2 s).
    @addaleax
    addaleax committed Jan 29, 2018
    Copy the full SHA
    c7f7b03 View commit details
Showing with 5 additions and 5 deletions.
  1. +5 −5 test/parallel/test-tls-session-cache.js
10 changes: 5 additions & 5 deletions test/parallel/test-tls-session-cache.js
View file
Original file line number Diff line number Diff line change
@@ -69,11 +69,11 @@ function doTest(testOptions, callback) {
server.on('newSession', function(id, data, cb) {
++newSessionCount;
// Emulate asynchronous store
setTimeout(function() {
setImmediate(() => {
assert.ok(!session);
session = { id, data };
cb();
}, 1000);
});
});
server.on('resumeSession', function(id, callback) {
++resumeCount;
@@ -89,9 +89,9 @@ function doTest(testOptions, callback) {
}

// Just to check that async really works there
setTimeout(function() {
setImmediate(() => {
callback(null, data);
}, 100);
});
});

server.listen(0, function() {
@@ -132,7 +132,7 @@ function doTest(testOptions, callback) {
}
assert.strictEqual(code, 0);
server.close(common.mustCall(function() {
setTimeout(callback, 100);
setImmediate(callback);
}));
}));
}