Skip to content

Commit 695ed67

Browse files
committedJan 23, 2018
doc: split CONTRIBUTING.md
PR-URL: nodejs#18271 Fixes: nodejs#17842 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 6a56a0a commit 695ed67

File tree

7 files changed

+844
-820
lines changed

7 files changed

+844
-820
lines changed
 

‎.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
1313
- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
1414
- [ ] tests and/or benchmarks are included
1515
- [ ] documentation is changed or added
16-
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)
16+
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)
1717

1818
##### Affected core subsystem(s)
1919
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->

‎COLLABORATOR_GUIDE.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ The TSC should serve as the final arbiter where required.
437437
author when squashing.
438438

439439
Review the commit message to ensure that it adheres to the guidelines outlined
440-
in the [contributing](./CONTRIBUTING.md#commit-message-guidelines) guide.
440+
in the [contributing](./doc/guides/contributing/pull-requests.md#commit-message-guidelines) guide.
441441

442442
Add all necessary [metadata](#metadata) to commit messages before landing.
443443

@@ -467,7 +467,7 @@ $ git checkout master
467467
```
468468

469469
Update the tree (assumes your repo is set up as detailed in
470-
[CONTRIBUTING.md](CONTRIBUTING.md#step-1-fork)):
470+
[CONTRIBUTING.md](./doc/guides/contributing/pull-requests.md#step-1-fork)):
471471

472472
```text
473473
$ git fetch upstream
@@ -562,7 +562,7 @@ commit logs, ensure that they are properly formatted, and add
562562
`Reviewed-By` lines.
563563

564564
* The commit message text must conform to the
565-
[commit message guidelines](./CONTRIBUTING.md#commit-message-guidelines).
565+
[commit message guidelines](./doc/guides/contributing/pull-requests.md#commit-message-guidelines).
566566

567567
<a name="metadata"></a>
568568
* Modify the original commit message to include additional metadata regarding

0 commit comments

Comments
 (0)