Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better description 2 / don´t overwrite phPch #134

Open
richbar88 opened this issue Aug 17, 2018 · 0 comments
Open

better description 2 / don´t overwrite phPch #134

richbar88 opened this issue Aug 17, 2018 · 0 comments
Labels
code review This issue originated from a code review

Comments

@richbar88
Copy link
Collaborator

richbar88 commented Aug 17, 2018

https://github.com/mmuellerstoffels/GBSTools/blob/7a20352a8b83e60f675273a79e43e3bfa5dd3385/GBSTool/GBSModel/SystemOperations.py#L241-L254
Suggestion: This part needs better description about the variables and about what is being done
here.
“phPch” is also overwritten here in line 202 (and was first calculated in line 200).

@richbar88 richbar88 changed the title better description 2 better description 2 / don´t overwrite phPch Aug 17, 2018
@richbar88 richbar88 added the code review This issue originated from a code review label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review This issue originated from a code review
Projects
None yet
Development

No branches or pull requests

1 participant