Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullability in javascript proxy types in abp built-in modules #22153

Open
1 task done
hillin opened this issue Feb 14, 2025 · 0 comments
Open
1 task done

Fix nullability in javascript proxy types in abp built-in modules #22153

hillin opened this issue Feb 14, 2025 · 0 comments

Comments

@hillin
Copy link

hillin commented Feb 14, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Since we have rolled out #22120, all (well, most) user-generated proxies now have nullabilities correctly reflect their backend counterparts. However in abp's built-in modules, some types still have incorrect nullability. E.g. EntityDto<TKey> in the @abp/ng.core package:

export declare class EntityDto<TKey = string> {
    id?: TKey;   // should not be nullable
    constructor(initialValues?: Partial<EntityDto<TKey>>);
}

Describe the solution you'd like

Update these types with correct nullability.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants