Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about collision metric #2

Open
InhwanBae opened this issue Apr 24, 2022 · 1 comment
Open

Question about collision metric #2

InhwanBae opened this issue Apr 24, 2022 · 1 comment

Comments

@InhwanBae
Copy link

Hi @YuejiangLIU

Thank you so much for this great work!

I have a question about the collision ratio results. ECCV2022 version of Trajectron++ has an issue that future two GT coordinates were additionally used while pre-processing the observed trajectories (issues #26 #40 #53). Therefore, when forecasting the trajectory, the first two frames can be predicted almost accurately, and I believe that two subsequent coordinates can also be estimated accurately using this additional information. Note that the solution to these issues has been updated on Trajectron++ GitHub.

As mentioned in the paper, the evaluation of collision rate is focused on the first four prediction steps. If so, my concern is that this issue of Trajectron++ affects the collision results in the paper.

Thank you!

@YuejiangLIU
Copy link
Owner

YuejiangLIU commented Apr 30, 2022

Hi @InhwanBae,

Thank you for your comments! This is a really great point!

In fact, I did notice in our trajectron++ evaluations last year that there were almost no collisions at all in the first two predicted steps. As a result, the collision rate of the trajectron++ was globally much lower than other base models. I previously thought it was simply because of the design the trajectron++ being better. But it's probably more related to the information leakage in their pre-processing, as you mentioned.

Unfortunately, I was not aware this underlying issue. Our code was actually developed and released before the commit that you shared.

The main goal of our experiment here is to compare forecasting models (e.g. trajectron++) trained with and without our method (social contrastive loss + negative data augmentation). In this regard, I guess the issue in the trajectron++ baseline does not affect our final conclusion much, but the collision numbers would have been larger globally if without the information leakage.

Thanks,
Yuejiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants