Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub-optimal math functions #92

Closed
sbc100 opened this issue Aug 19, 2019 · 1 comment
Closed

sub-optimal math functions #92

sbc100 opened this issue Aug 19, 2019 · 1 comment

Comments

@sbc100
Copy link
Member

sbc100 commented Aug 19, 2019 •
edited
Loading

Currently we are including the C implementations of several math function:

  • rint
  • rintf
  • copysignf
  • floor
  • ceil
  • trunc
  • fabs
  • copysign
  • sqrt

This means that any code compiled with -fno-builtin will end up with sub-optimal implementations and because wasi-libc itself is compiled with -fno-builtin any internal references to these functions will be sub-optimal.

This was recently fixed in emscripten via: emscripten-core/emscripten#9239 emscripten-core/emscripten#9250

However, a cleaner fix might be to use arch-specific implementations like, for example:
./libc-top-half/musl/src/math/i386/rintf.s
@sunfishcode
Copy link
Member

This was fixed in 1645076.

@sbc100
Copy link
Member Author

sbc100 commented Aug 19, 2019

Ah thanks, sorry couldn't find the fix

@sbc100 sbc100 closed this as completed Aug 19, 2019
@oovm oovm mentioned this issue Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbc100 @sunfishcode