Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi-sockets: Allow TCP connect from a Bound state. #9502

Merged
merged 1 commit into from
Oct 23, 2024
Merged

wasi-sockets: Allow TCP connect from a Bound state. #9502

merged 1 commit into from
Oct 23, 2024
+29 −2

Conversation

badeend
Copy link
Contributor

@badeend badeend commented Oct 23, 2024

Typically, bind is only used on listener sockets. But it is perfectly fine to bind client sockets too.
Wasmtime was unnecessarily restrictive here.

Fixes WebAssembly/wasi-libc#540 encountered by @pavelsavara while trying to get the dotnet testsuite to run.

@badeend
Allow connecting from a Bound state.
Loading
Loading status checks…
fa8bb4c
@badeend badeend requested a review from a team as a code owner October 23, 2024 12:50
@badeend badeend requested review from alexcrichton and removed request for a team October 23, 2024 12:50
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Oct 23, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Oct 23, 2024
Merged via the queue into bytecodealliance:main with commit 7dfe174 Oct 23, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasi-sockets: TCP connect from a Bound state.
2 participants
@badeend @alexcrichton