Remove the signal constants and proc_raise function. #278
+9
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WASI signal constants and proc_raise function were removed in the latest [ephemeral], which had been scheduled to be in the next snapshot, however WASI itself is now transitioning away from the snapshot system. WASI libc will also be transitioning to updated wit specs once they're ready, however until that time, we can make the simple change of removing these signal constants to avoid confusion. Fixes #271. Fixes #272. [ephemeral]: https://github.com/WebAssembly/WASI/tree/main/phases/ephemeral/witx
sbc100
reviewed
Mar 23, 2022
sbc100
approved these changes
Mar 23, 2022
yamt
added a commit
to yamt/wasm-micro-runtime
that referenced
this pull request
Apr 27, 2022
…lable
Many of these signal constants are not available on NuttX.
Maybe we can remove these signal stuff sooner or later.
WebAssembly/WASI#7
WebAssembly/wasi-libc#278
wenyongh
pushed a commit
to bytecodealliance/wasm-micro-runtime
that referenced
this pull request
Apr 27, 2022
…lable (#1125) Many of these signal constants are not available on NuttX. Maybe we can remove these signal stuff sooner or later: WebAssembly/WASI#7 WebAssembly/wasi-libc#278
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…lable (bytecodealliance#1125) Many of these signal constants are not available on NuttX. Maybe we can remove these signal stuff sooner or later: WebAssembly/WASI#7 WebAssembly/wasi-libc#278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASI signal constants and proc_raise function were removed in the
latest ephemeral, which had been scheduled to be in the next snapshot,
however WASI itself is now transitioning away from the snapshot system.
WASI libc will also be transitioning to updated wit specs once they're
ready, however until that time, we can make the simple change of
removing these signal constants to avoid confusion.
Fixes #271.
Fixes #272.